Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the functionality from RollOver Daily Todos plugin #559

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Trap101
Copy link

@Trap101 Trap101 commented Apr 28, 2024

Added pass_over_todos (potentially rename to roll_over_daily_todos?) option which allows moving any incompleted todo from yesterday onto today's daily note.

@jacostag
Copy link

This is exactly what I been looking for. Thanks, I hope it gets merged soon

@jacostag
Copy link

I manually added the changes to my config and is not working :(
I can read the changes and it looks good to me, it searches for the empty checkboxes from the day before and updates the content of the new note, but I am just learning lua and for now I can not pin point the issue, I will try to debug it

@jacostag
Copy link

ok, figure it out, the only thing missing was to add the option to the daily notes section to pass_over_todos = true
This works great

@jacostag
Copy link

@Trap101 hey, there is a typo, lua/obsidian/client.lua maybe that is why this feature has not been merged
You replaced the y for a :
---@type string
---@t:pe string

@epwalsh
Copy link
Owner

epwalsh commented Jul 12, 2024

@Trap101 @jacostag thanks for this, I meant to review a while ago but it fell off my radar. @Trap101 if you're still around could you fix the typo and merge conflicts? Then I'll give it a proper review.

@Trap101
Copy link
Author

Trap101 commented Aug 3, 2024

Sorry for taking so long, conflict has been resolved and just tested, the functionality should be working. I am not the best at naming so change the settings / variable names as they should be

@aniketgm
Copy link

aniketgm commented Dec 3, 2024

@epwalsh @Trap101, If all checks have passed can we get this into obsidian pls. This is a really nice feature to have. However, it has been open for a while now. The manual rolling over todo's from previous day, is really a pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants