Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor client.today and client.yesterday #154

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

noriapi
Copy link
Contributor

@noriapi noriapi commented Jul 21, 2023

Since most parts of client.today and client.yesterday are the same code, i extracted it as client._daily.

@noriapi
Copy link
Contributor Author

noriapi commented Jul 21, 2023

Sorry, I don't know how the refactoring should be described in keep a changelog.

@epwalsh
Copy link
Owner

epwalsh commented Jul 21, 2023

Thanks @noriapi, this is great. For the CHANGELOG, I would just add something like this:

### Changed

- (internal) Refactored daily note creation

@noriapi
Copy link
Contributor Author

noriapi commented Jul 22, 2023

Thanks @noriapi, this is great. For the CHANGELOG, I would just add something like this:

### Changed

- (internal) Refactored daily note creation

Thank you, I added it to CHANGELOG.

Copy link
Owner

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @noriapi :)

@epwalsh epwalsh merged commit 8fcc8d8 into epwalsh:main Jul 24, 2023
5 checks passed
@noriapi noriapi deleted the refactor-daily branch July 26, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants