Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual studio project #138

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+154 −0
Open

Add visual studio project #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bc18225
Try and setup for Visual Studio.
kiates Apr 5, 2023
dda9b65
Add entry points for launching from a debugger.
kiates Apr 5, 2023
e309a92
Always enable debug logging when running from Visual Studio.
kiates Apr 6, 2023
3af83b4
Remove generated/unneeded files.
kiates Apr 7, 2023
59e67ee
Use sample project as debug parameters.
kiates Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@ __pycache__/
src/*.egg-info/
.venv/
.vscode/
_ReSharper.Caches/
TestResults/
119 changes: 119 additions & 0 deletions dali-rp2.pyproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,119 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" DefaultTargets="Build">
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
<SchemaVersion>2.0</SchemaVersion>
<ProjectGuid>{21de6965-e7a9-45bf-bc35-9aafe37f7ddf}</ProjectGuid>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this id? Can it be shared on other user's machines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a unique identify that represents this pyproject if it is inserted into a solution file. It isn't user specific.

<ProjectHome />
<StartupFile>src\dali\plugin\country\us.py</StartupFile>
<SearchPath />
<WorkingDirectory>.</WorkingDirectory>
<OutputPath>.</OutputPath>
<ProjectTypeGuids>{888888a0-9f3d-457c-b088-3a5042f75d52}</ProjectTypeGuids>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this id? Can it be shared on other user's machines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a unique ID defined by Microsoft that indicates that this project is a python project type. It is the same for all python projects.

<LaunchProvider>Standard Python launcher</LaunchProvider>
<InterpreterId>MSBuild|.venv|$(MSBuildProjectFullPath)</InterpreterId>
<CommandLineArguments>-t 1 -s -o output -p test_ config\test_config.ini</CommandLineArguments>
<EnableNativeCodeDebugging>False</EnableNativeCodeDebugging>
<TestFramework>pytest</TestFramework>
<UnitTestPattern>test*.py</UnitTestPattern>
<UnitTestRootDirectory>tests</UnitTestRootDirectory>
<Environment>LOG_LEVEL=DEBUG</Environment>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)' == 'Debug'" />
<PropertyGroup Condition="'$(Configuration)' == 'Release'" />
<PropertyGroup>
<VisualStudioVersion Condition=" '$(VisualStudioVersion)' == '' ">10.0</VisualStudioVersion>
</PropertyGroup>
<ItemGroup>
<Content Include="config\test_config.ini" />
<Content Include="input\test_ods_rp2_input.ini" />
<Content Include="mypy.ini" />
</ItemGroup>
<ItemGroup>
<Compile Include="setup.py" />
<Compile Include="src\dali\abstract_ccxt_input_plugin.py" />
<Compile Include="src\dali\abstract_input_plugin.py" />
<Compile Include="src\dali\abstract_pair_converter_plugin.py" />
<Compile Include="src\dali\abstract_transaction.py" />
<Compile Include="src\dali\cache.py" />
<Compile Include="src\dali\ccxt_pagination.py" />
<Compile Include="src\dali\configuration.py" />
<Compile Include="src\dali\configuration_generator.py" />
<Compile Include="src\dali\dali_main.py" />
<Compile Include="src\dali\data\__init__.py" />
<Compile Include="src\dali\historical_bar.py" />
<Compile Include="src\dali\intra_transaction.py" />
<Compile Include="src\dali\in_transaction.py" />
<Compile Include="src\dali\logger.py" />
<Compile Include="src\dali\ods_generator.py" />
<Compile Include="src\dali\out_transaction.py" />
<Compile Include="src\dali\plugin\country\jp.py" />
<Compile Include="src\dali\plugin\country\us.py" />
<Compile Include="src\dali\plugin\country\__init__.py" />
<Compile Include="src\dali\plugin\input\csv\binance_com_supplemental.py" />
<Compile Include="src\dali\plugin\input\csv\bitbank_supplemental.py" />
<Compile Include="src\dali\plugin\input\csv\blockfi.py" />
<Compile Include="src\dali\plugin\input\csv\coincheck_supplemental.py" />
<Compile Include="src\dali\plugin\input\csv\ledger.py" />
<Compile Include="src\dali\plugin\input\csv\manual.py" />
<Compile Include="src\dali\plugin\input\csv\nexo.py" />
<Compile Include="src\dali\plugin\input\csv\pionex.py" />
<Compile Include="src\dali\plugin\input\csv\trezor.py" />
<Compile Include="src\dali\plugin\input\csv\trezor_old.py" />
<Compile Include="src\dali\plugin\input\csv\trezor_v2.py" />
<Compile Include="src\dali\plugin\input\csv\__init__.py" />
<Compile Include="src\dali\plugin\input\ods\rp2_input.py" />
<Compile Include="src\dali\plugin\input\ods\__init__.py" />
<Compile Include="src\dali\plugin\input\__init__.py" />
<Compile Include="src\dali\plugin\pair_converter\ccxt.py" />
<Compile Include="src\dali\plugin\pair_converter\ccxt_binance.py" />
<Compile Include="src\dali\plugin\pair_converter\ccxt_kraken.py" />
<Compile Include="src\dali\plugin\pair_converter\historic_crypto.py" />
<Compile Include="src\dali\plugin\pair_converter\__init__.py" />
<Compile Include="src\dali\plugin\__init__.py" />
<Compile Include="src\dali\transaction_resolver.py" />
<Compile Include="src\dali\__init__.py" />
<Compile Include="tests\ods_diff.py" />
<Compile Include="tests\test_cache.py" />
<Compile Include="tests\test_historical_bar.py" />
<Compile Include="tests\test_ods_output_diff.py" />
<Compile Include="tests\test_plugin_binance_com.py" />
<Compile Include="tests\test_plugin_binance_com_supplemental_csv.py" />
<Compile Include="tests\test_plugin_bitbank_supplemental_csv.py" />
<Compile Include="tests\test_plugin_ccxt.py" />
<Compile Include="tests\test_plugin_coinbase.py" />
<Compile Include="tests\test_plugin_coinbase_pro.py" />
<Compile Include="tests\test_plugin_coincheck_supplemental.py" />
<Compile Include="tests\test_plugin_historic_crypto.py" />
<Compile Include="tests\test_plugin_kraken_csv_download.py" />
<Compile Include="tests\test_plugin_ods_rp2_input.py" />
<Compile Include="tests\test_plugin_pionex.py" />
<Compile Include="tests\test_transaction_resolver.py" />
</ItemGroup>
<ItemGroup>
<Folder Include="config" />
<Folder Include="input" />
<Folder Include="src\" />
<Folder Include="src\dali" />
<Folder Include="src\dali\data" />
<Folder Include="src\dali\plugin" />
<Folder Include="src\dali\plugin\country" />
<Folder Include="src\dali\plugin\input" />
<Folder Include="src\dali\plugin\input\csv" />
<Folder Include="src\dali\plugin\input\ods" />
<Folder Include="src\dali\plugin\pair_converter" />
<Folder Include="tests" />
</ItemGroup>
<ItemGroup>
<Interpreter Include=".venv\">
<Id>.venv</Id>
<Description>.venv (Python 3.9)</Description>
<InterpreterPath>Scripts\python.exe</InterpreterPath>
<WindowsInterpreterPath>Scripts\pythonw.exe</WindowsInterpreterPath>
<Version>3.9</Version>
<Architecture>X64</Architecture>
<PathEnvironmentVariable>PYTHONPATH</PathEnvironmentVariable>
</Interpreter>
</ItemGroup>
<Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\Python Tools\Microsoft.PythonTools.targets" />
</Project>
23 changes: 23 additions & 0 deletions dali-rp2.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
VisualStudioVersion = 17.6.33513.286
MinimumVisualStudioVersion = 10.0.40219.1
Project("{888888A0-9F3D-457C-B088-3A5042F75D52}") = "dali-rp2", "dali-rp2.pyproj", "{21DE6965-E7A9-45BF-BC35-9AAFE37F7DDF}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Release|Any CPU = Release|Any CPU
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{21DE6965-E7A9-45BF-BC35-9AAFE37F7DDF}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{21DE6965-E7A9-45BF-BC35-9AAFE37F7DDF}.Release|Any CPU.ActiveCfg = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {939DD0FF-121C-4BCB-9181-BCB6BBEEA96E}
EndGlobalSection
EndGlobal
5 changes: 5 additions & 0 deletions src/dali/plugin/country/jp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,8 @@
# JP-specific entry point
def dali_entry() -> None:
dali_main(JP())

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDE integration shouldn't require modifying the source code. I usually debug with print, but I did use the VSCode debugger occasionally in the past (not sure how similar it is to Visual Studio). VSCode can be configured to debug DaLI and RP2 without changing the source: I used .venv/bin/dali_us as the entry point.

Copy link
Contributor Author

@kiates kiates Apr 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can create IDE specific dali_us/dali_jp.py files for debugging, but I don't think that will be as simple as just adding this entry point. I couldn't figure out any way to get visual studio to start using the exe's generated by the "installer".

See this branch for what it would look like: https://github.com/kiates/dali-rp2/tree/visual-studio-project-improvements

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried using .venv/bin/dali_us and .venv/bin/dali_jp as entry points? They should not require modification.

# This traditional entry point is used for debugging purposes only, dali_entry()
# is normally called through the use of an installed console script in setup.py.
if __name__ == '__main__':
dali_entry()
5 changes: 5 additions & 0 deletions src/dali/plugin/country/us.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,8 @@
# US-specific entry point
def dali_entry() -> None:
dali_main(US())

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

# This traditional entry point is used for debugging purposes only, dali_entry()
# is normally called through the use of an installed console script in setup.py.
if __name__ == '__main__':
dali_entry()