Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding options for ioc main #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZohebShaikh
Copy link

This PR is created in relation to this issue epics-base/pvxs#49

@mdavidsaver
Copy link
Member

CI failures on OSX are unrelated (#25) to this PR.

@OCopping OCopping self-requested a review September 4, 2024 10:33
@OCopping
Copy link
Contributor

OCopping commented Sep 5, 2024

Are you able to squash these commits into only a couple please?

@ZohebShaikh
Copy link
Author

Are you able to squash these commits into only a couple please?

I've gone ahead and squashed the commits into a single one as requested. Please feel free to let me know if there's anything else you'd like me to adjust!

@OCopping
Copy link
Contributor

OCopping commented Sep 5, 2024

CI is broken due to actions/upload-artifact@v2 being deprecated. Fixing in #29

@ZohebShaikh
Copy link
Author

ZohebShaikh commented Oct 2, 2024

@OCopping I noticed that #29 has been merged. Is this PR ready to be merged as well? I'm unable to re-run the CI to verify.

@OCopping
Copy link
Contributor

OCopping commented Oct 2, 2024

@ZohebShaikh can you rebase this on main so we can try the CI again?

@ZohebShaikh
Copy link
Author

@OCopping I noticed the CI is passing. Could we proceed with the merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants