-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): Unified frontend code style #1923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er) (#1816) # Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. # How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration # Snapshots: Include snapshots for easier review. # Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have already rebased the commits and make the commit message conform to the project standard. - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] Any dependent changes have been merged and published in downstream modules
Dreammy23
changed the title
Feat/sprint update flow
feat: update flow and add lint tool to web
Aug 29, 2024
fangyinc
changed the title
feat: update flow and add lint tool to web
feat(web): Unified frontend code development style
Aug 29, 2024
fangyinc
changed the title
feat(web): Unified frontend code development style
feat(web): Unified frontend code style
Aug 29, 2024
hustcc
reviewed
Aug 30, 2024
csunny
previously approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, LGTM
fangyinc
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
yhjun1026
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+
csunny
pushed a commit
that referenced
this pull request
Sep 2, 2024
Co-authored-by: Fangyin Cheng <[email protected]> Co-authored-by: 谨欣 <[email protected]> Co-authored-by: 严志勇 <[email protected]> Co-authored-by: yanzhiyong <[email protected]>
Hopshine
pushed a commit
to Hopshine/DB-GPT
that referenced
this pull request
Sep 10, 2024
Co-authored-by: Fangyin Cheng <[email protected]> Co-authored-by: 谨欣 <[email protected]> Co-authored-by: 严志勇 <[email protected]> Co-authored-by: yanzhiyong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.