Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): Support armv8 machine #1585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

S0uLHun43r
Copy link

@S0uLHun43r S0uLHun43r commented May 30, 2024

old docker image can't support armv8, so add a new image for webserver

Description

docker support armv8 machine,new webserver docker image is https://hub.docker.com/repository/docker/tmsxb/dbgpt/

How Has This Been Tested?

Test passed

Snapshots:

Include snapshots for easier review.

Checklist:

  • [ ✔] My code follows the style guidelines of this project
  • [ ✔] I have already rebased the commits and make the commit message conform to the project standard.
  • [✔ ] I have performed a self-review of my own code
  • [ ✔] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

old docker image can't support armv8, so add a new image for webserver
@github-actions github-actions bot added the enhancement New feature or request label May 30, 2024
@csunny
Copy link
Collaborator

csunny commented May 30, 2024

@S0uLHun43r Thank you for your PR, very cool~

@fangyinc
Copy link
Collaborator

fangyinc commented Jun 4, 2024

Hi, @S0uLHun43r, thanks for your contribution. But I think we should build multi-platform images instead of adding a new image (different name and version).
Are you interested in fixing docker-image-publish.yml to support multi-platform images?

In addition, if the platform is linux/arm/v7 or linux/arm/v8, you can consider using ubuntu22.04 as the base image instead of 'nvidia/cuda:12.1.0-runtime-ubuntu22.04' .

@S0uLHun43r
Copy link
Author

Hi, @S0uLHun43r, thanks for your contribution. But I think we should build multi-platform images instead of adding a new image (different name and version). Are you interested in fixing docker-image-publish.yml to support multi-platform images?

In addition, if the platform is linux/arm/v7 or linux/arm/v8, you can consider using ubuntu22.04 as the base image instead of 'nvidia/cuda:12.1.0-runtime-ubuntu22.04' .

okay,I'll try to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants