fix: Fix bug for issue #1669 (#1672)

Co-authored-by: WangTing <[email protected]> Co-authored-by: aries_ckt <[email protected]>
eosphoros-ai · Jun 28, 2024 · cd2163e · cd2163e
1 parent 2eeef2f
commit cd2163e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/dbgpt/app/knowledge/document_db.py b/dbgpt/app/knowledge/document_db.py
@@ -219,6 +219,7 @@ def get_knowledge_documents_count_bulk(self, space_names):
         )
 
         results = counts_query.all()
+        session.close()
         docs_count = {result.space: result.document_count for result in results}
         return docs_count
 
@@ -253,7 +254,9 @@ def update_knowledge_document(self, document: KnowledgeDocumentEntity):
         session = self.get_raw_session()
         updated_space = session.merge(document)
         session.commit()
-        return updated_space.id
+        update_space_id = updated_space.id
+        session.close()
+        return update_space_id
 
     #
     def raw_delete(self, query: KnowledgeDocumentEntity):

diff --git a/dbgpt/app/knowledge/service.py b/dbgpt/app/knowledge/service.py
@@ -220,9 +220,14 @@ async def document_summary(self, request: DocumentSummaryRequest):
             document.status not in [SyncStatus.RUNNING.name]
             and len(chunk_entities) == 0
         ):
-            self._sync_knowledge_document(
-                space_name=document.space,
-                doc=document,
+            from dbgpt.serve.rag.service.service import Service
+
+            rag_service = Service.get_instance(CFG.SYSTEM_APP)
+            space = rag_service.get({"name": document.space})
+            document_vo = KnowledgeDocumentEntity.to_document_vo(documents)
+            await rag_service._sync_knowledge_document(
+                space_id=space.id,
+                doc_vo=document_vo[0],
                 chunk_parameters=chunk_parameters,
             )
         knowledge = KnowledgeFactory.create(

diff --git a/dbgpt/storage/vector_store/chroma_store.py b/dbgpt/storage/vector_store/chroma_store.py
@@ -133,7 +133,7 @@ def similar_search_with_scores(
                 Chunk(
                     content=chroma_result[0],
                     metadata=chroma_result[1] or {},
-                    score=chroma_result[2],
+                    score=(1 - chroma_result[2]),
                 )
             )
             for chroma_result in zip(
@@ -195,7 +195,7 @@ def convert_metadata_filters(
         where_filters = {}
         filters_list = []
         condition = filters.condition
-        chroma_condition = f"${condition}"
+        chroma_condition = f"${condition.value}"
         if filters.filters:
             for filter in filters.filters:
                 if filter.operator: