Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes to test-cli #1084

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Small fixes to test-cli #1084

merged 1 commit into from
Oct 1, 2024

Conversation

ameba23
Copy link
Contributor

@ameba23 ameba23 commented Oct 1, 2024 •
edited
Loading

I wanted to try out our latest changes with docker-compose, and i ran into some problems.

  • Program hashes were being interpreted as program version numbers, making it impossible to register without giving a version number:
/r/s/e/e/c/test-cli (master●●)$ cargo run --release -- register -m //Alice 3289435006003c3c83da5582d779d810c343f177fb1fecddbaca5d326ef9d9b3
    Finished `release` profile [optimized] target(s) in 0.55s
     Running `/home/turnip/radish/src/entropy/entropy-core/target/release/entropy-test-cli register -m //Alice 3289435006003c3c83da5582d779d810c343f177fb1fecddbaca5d326ef9d9b3`
error: invalid value '3289435006003c3c83da5582d779d810c343f177fb1fecddbaca5d326ef9d9b3' for '[PROGRAM_VERSION_NUMBERS]...': invalid digit found in string
  • When storing a program, you cannot find out its full hash using the CLI, because hashes are displayed 'pretty', eg: 0x3289…d9b3, making it impossible to copy and paste them.

@HCastano HCastano merged commit f8cd3a2 into master Oct 1, 2024
7 of 8 checks passed
@HCastano HCastano deleted the peg/small-fixes-test-cli branch October 1, 2024 21:26
ameba23 added a commit that referenced this pull request Oct 2, 2024
@ameba23
Merge branch 'master' into peg/handle-pck-certs
a1ae9e4 
* master:
  Bump clap from 4.5.18 to 4.5.19 in the patch-dependencies group (#1091)
  Avoid panic by checking that we have a non-signing validator before selecting one (#1083)
  Fix master build (#1088)
  Small fixes to `test-cli` (#1084)
  Pregenerate keyshares sets for all possible initial signer comittees (#1073)
  Fix master build (#1079)
  Bump reqwest from 0.12.7 to 0.12.8 in the patch-dependencies group (#1082)
  Block tss chain when signer (#1078)
  Run multiple test validator (#1074)
  Bump tempfile from 3.12.0 to 3.13.0 (#1076)
  Bump axum from 0.7.6 to 0.7.7 in the patch-dependencies group (#1075)
  Unignore register and sign integration test, and do a non-mock jumpstart (#1070)
  No unbonding when signer or next signer (#1031)
  Add `/relay_tx` endpoint (#1050)
  Fix how pre-generated keyshares are added for tests (#1061)
  Handle Provisioning Certification Keys (PCKs) (#1051)
  Bump async-trait from 0.1.82 to 0.1.83 in the patch-dependencies group (#1067)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HCastano HCastano HCastano approved these changes

@JesseAbram JesseAbram Awaiting requested review from JesseAbram

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ameba23 @HCastano