Confusion around constants for t and n

[ameba23]

entropy-shared has the following constants:

entropy-core/crates/shared/src/constants.rs

Line 36 in f712a85

pub const SIGNING_PARTY_SIZE: usize = 2;

entropy-core/crates/shared/src/constants.rs

Line 67 in f712a85

pub const TOTAL_SIGNERS: u8 = 3;

entropy-core/crates/shared/src/constants.rs

Line 70 in f712a85

pub const SIGNER_THRESHOLD: u8 = 2;

SIGNING_PARTY_SIZE is used by the registry pallet to check we have the right number of confirmations following network DKG.

But i would expect this to be 3, not 2. I think it would be good to have just two constants to avoid confusion.

[JesseAbram]

yes Signing party size should be replaced by total signers and signer threshold, will add this to #941

[ameba23]

Fixed in #971