Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SpecialPageStatistics to match table schema for MediaWiki 1.35 #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

djflux
Copy link

@djflux djflux commented Jul 8, 2022

This change is related to #120. The revision table schema changed and the data that Special:PageStatistics gathers is now located in a couple of tables:

  • revision_actor_temp - contains the page revisions and the actor_id (formerly rev_user in revision table)
  • actor - table contains actor_id and actor_name (formerly rev_user_text)

The changes update the SELECT statement and the relevant Linker::UserLink code.

Tested on real Red Hat Enterprise Linux version 8.6 installed via this kickstart file:

https://www.mediawiki.org/w/index.php?title=User:Djflux/rhel8-min-cdrom-text&action=raw

Demo Wiki installed via the rhel8-35.x branch of meza from here: https://github.com/djflux/meza/tree/rhel8-35.x

Wiki versions

Product Version
MediaWiki 1.35.7 (c6ddc4a)
PHP 7.4.19 (fpm-fcgi)
MariaDB 10.3.32-MariaDB-log
ICU 60.3
Elasticsearch 6.8.23
Extension Version License Description Authors
WatchAnalytics 3.2.0 (adf3421) 16:52, 26 April 2022 License Encouraging good distribution of watchers James Montalvo

@olsonjaredm
Copy link

olsonjaredm commented Sep 20, 2022

Concur with this pull request, tested working on 1.35.6 and fixes error below. Thanks djflux.

Error 1054: Unknown column 'rev.rev_user' in 'field list' (c110d_mysql_db)
Function: SpecialPageStatistics::renderPageStats
Product Version
MediaWiki 1.35.6
PHP 7.4.30 (apache2handler)
MariaDB 10.6.7-MariaDB
ICU 60.3
Elasticsearch 6.8.23
Lua 5.1.5

@djflux
Copy link
Author

djflux commented Feb 3, 2023

For Your Situational Awareness (FYSA), the table schema changed again in MW 1.39 so this PR will work for only MW 1.35. Check here for more fixes for MW 1.39 compatibility:

https://github.com/djflux/WatchAnalytics/tree/REL1_39
djflux#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants