Try extracting attestations in rego #939
Draft
+47
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experimental DNM
simonbaird
force-pushed
the
builtin-experiments
branch
from
f25e524
to
b1ad46f
Compare
lcarva
reviewed
Mar 28, 2024
| info := ec.sigstore.verify_attestation(_image_ref, _sigstore_opts) | ||
|
|
||
| # This doesn't work for some reason. | ||
| # Todo: Fix this and add more checks here probably. |
There was a problem hiding this comment.
Yeah, that's the challenge with this approach. It's hard to propagate errors. You have to explicitly look for them.
|
|
||
| atts := [a | | ||
| some att in info.attestations | ||
| a := { |
There was a problem hiding this comment.
Hmm if conversion is needed, I probably messed up the output of ec.sigstore.verify_attestation.
|
Close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental DNM