Create EC policy config for validating Task definitions #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lgtm, but I'm a bit fuzzy on the hack/update-infra-deployments.sh stuff. |
The `.name` attribute of each policy now has a different meaning. Instead, now use the key value as this is what is used to created the policy config file. Signed-off-by: Luiz Carvalho <[email protected]>
Ref: EC-358 Signed-off-by: Luiz Carvalho <[email protected]>
|
Update PR to not rely on the Thanks for the review! I'm gonna go ahead and merge this. I will watch the flow of things to make sure it does work as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: EC-358
This adds a policy config that can be used to verify Task definitions. Since this requires policies from a different namespace (task instead of release), this is handled as a new "environment".
The
update-infra-deployments.shscript is adjusted to handle propagating updates from the new config to the infra-deployments repo. It should be a no-op at first because the infra-deployments repo doesn't contain any instances of the ec-task-policy bundle image. It's important to do this now so things don't break when we do add it there.A separate commit is added to fix the verify-policy-sources script which was broken.