Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #164

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Main #164

merged 4 commits into from
Nov 6, 2024

Conversation

entelecheia
Copy link
Owner

@entelecheia entelecheia commented Nov 6, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Summary by Sourcery

Introduce a new script to convert Poetry pyproject.toml to UV format and migrate project metadata to UV PEP 517. Update the virtual environment path and refactor code for better readability. Adjust the GitHub Actions workflow and git commit message format. Add .venv to .gitignore.

New Features:

  • Add an executable script to convert Poetry pyproject.toml to UV format.

Enhancements:

  • Migrate from Poetry to UV PEP 517 project metadata in pyproject.toml.
  • Change the virtual environment path to a local .venv.
  • Refactor the extract_metadata function to improve readability and maintainability.

Build:

  • Update the git commit message format in pyproject.toml.

CI:

  • Update the GitHub Actions workflow to use python-semantic-release version 9.12.1.

Chores:

  • Add .venv to the .gitignore file.

github-actions and others added 4 commits October 23, 2024 07:31
Automatically generated by python-semantic-release
Bumps [python-semantic-release/python-semantic-release](https://github.com/python-semantic-release/python-semantic-release) from 9.12.0 to 9.12.1.
- [Release notes](https://github.com/python-semantic-release/python-semantic-release/releases)
- [Changelog](https://github.com/python-semantic-release/python-semantic-release/blob/master/CHANGELOG.md)
- [Commits](python-semantic-release/python-semantic-release@v9.12.0...v9.12.1)

---
updated-dependencies:
- dependency-name: python-semantic-release/python-semantic-release
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…thon-semantic-release/python-semantic-release-9.12.1
Copy link

codesandbox bot commented Nov 6, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor β€’ VS Code β€’ Insiders

Open Preview

Copy link

sourcery-ai bot commented Nov 6, 2024

Reviewer's Guide by Sourcery

This PR implements several refactoring changes focused on migrating from Poetry to UV build system, along with version updates and configuration changes. The main changes include updating the build system configuration, modifying version handling, and updating GitHub Actions workflow.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Migration from Poetry to UV build system
  • Updated version path from tool.poetry.version to project.version
  • Added new executable script for Poetry to UV conversion
  • Removed legacy Poetry-related script
pyproject.toml
CHANGELOG.md
Virtual environment configuration updates
  • Changed virtual environment path to local .venv
  • Added .venv to gitignore list
CHANGELOG.md
Documentation and configuration cleanup
  • Removed .readthedocs.yaml configuration file
  • Updated semantic release commit message format
pyproject.toml
CHANGELOG.md
CI/CD workflow updates
  • Updated python-semantic-release action version to v9.12.1
  • Updated DOTFILES_VERSION to 0.42.0
.github/workflows/release.yaml
chezmoi/.chezmoidata.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@zube zube bot added the [zube]: Inbox label Nov 6, 2024
@entelecheia entelecheia merged commit f62fd6d into release Nov 6, 2024
1 check was pending
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Nov 6, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @entelecheia - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please fill out the PR description template, particularly explaining the motivation for migrating from Poetry to UV and any post-deployment steps that might be needed.
Here's what I looked at during the review
  • 🟒 General issues: all looks good
  • 🟒 Security: all looks good
  • 🟒 Testing: all looks good
  • 🟒 Complexity: all looks good
  • 🟒 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click πŸ‘ or πŸ‘Ž on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant