Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react 18 + node + pnpm + next + jest + testing-library #154

Merged
merged 12 commits into from
Aug 7, 2024

Conversation

storywithoutend
Copy link
Contributor

@storywithoutend storywithoutend commented May 22, 2024

update development environment

fix: components using useTransitionState were not "pure" which causes them to break in React 18.

Copy link

cloudflare-workers-and-pages bot commented May 22, 2024

Deploying thorin with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1365513
Status: ✅  Deploy successful!
Preview URL: https://d5841d56.thorin.pages.dev
Branch Preview URL: https://offshoot1.thorin.pages.dev

View logs

@talentlessguy
Copy link
Contributor

talentlessguy commented Aug 1, 2024

suggestion: let's not use jest anymore. Vitest is much faster and is much less buggy (and supports ESM ootb)

timeout: {
enter: 0,
exit: 300,
},
preEnter: true,
})

useEffect(() => {
toggle(isOpen)
React.useEffect(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove React. please

@LeonmanRolls LeonmanRolls merged commit 89dbbb3 into main Aug 7, 2024
4 checks passed
@LeonmanRolls LeonmanRolls deleted the offshoot1 branch August 7, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants