Capsule integration final #883

LeonmanRolls · 2024-09-25T02:13:21Z

No description provided.

…usecapsule-integration-two

cloudflare-workers-and-pages · 2024-09-25T05:05:56Z

Deploying ens-app-v3 with Cloudflare Pages

Latest commit:	`145530a`
Status:	✅ Deploy successful!
Preview URL:	https://e5c66fdb.ens-app-v3.pages.dev
Branch Preview URL:	https://capsule-integration-final.ens-app-v3.pages.dev

View logs

…capsule-integration-final

Default to moonpay when balance is zero

…capsule-integration-final

TateB · 2024-10-24T04:42:04Z

src/components/ConnectButton.tsx

+  const isCapsuleConnected = getIsCapsuleConnected(wagmiConfig.state)
+


would this be better suited to use with wagmi's useConnections?

TateB · 2024-10-24T04:42:53Z

src/components/ConnectButton.tsx

+          isCapsuleConnected
+            ? {
+                label: t('wallet.myWallet'),
+                color: 'text',
+                icon: <WalletSVG />,
+                wrapper: (children: ReactNode, key: Key) => (
+                  <BaseLink href="https://connect.usecapsule.com/" key={key}>
+                    {children}
+                  </BaseLink>
+                ),
+              }
+            : null,


if you use ...[isCapsuleConnected ? [...] : []] you can avoid filtering

TateB · 2024-10-24T04:43:46Z

src/pages/_app.tsx

-
-import '@rainbow-me/rainbowkit/styles.css'
-
+// prettier-ignore-file


TateB · 2024-10-24T04:44:24Z

src/utils/query/RainbowKitWithCapsuleProvider.tsx

+
+const rainbowKitTheme: Theme = {
+  ...lightTheme({
+    // accentColor: thorinLightTheme.colors.accent, // requires a hex string color but thorinLightTheme returns a hsl string


TateB · 2024-10-24T04:45:53Z

src/utils/query/capsuleWallet.ts

+  githubUrl: 'https://github.com/ensdomains',
+  xUrl: 'https://twitter.com/ensdomains',


we have these elsewhere i think, would be nice to have a single reference

TateB · 2024-10-24T04:45:59Z

src/utils/query/capsuleWallet.ts

+  githubUrl: 'https://github.com/ensdomains',
+  xUrl: 'https://twitter.com/ensdomains',
+  homepageUrl: 'https://ens.domains/',
+  supportUrl: 'mailto:[email protected]',


is this a real email?

TateB · 2024-10-24T04:48:26Z

src/utils/query/wagmi.ts

-const isSupportedChain = (chainId: number): chainId is (typeof chains)[number]['id'] =>
-  chains.some((c) => c.id === chainId)
-
-// hotfix for wagmi bug
-wagmiConfig_.subscribe(
-  ({ connections, current }) => (current ? connections.get(current)?.chainId : undefined),
-  (chainId_) => {
-    const chainId = chainId_ || chains[0].id
-    // If chain is not configured, then don't switch over to it.
-    const isChainConfigured = isSupportedChain(chainId)
-    if (!isChainConfigured) return
-
-    return wagmiConfig_.setState((x) => ({
-      ...x,
-      chainId: chainId ?? x.chainId,
-    }))
-  },
-)
-


we still need these unless they went somewhere else, our logic means we're always defaulting to the 0th item in the chain array (without it it'll stay on the last connected supported chain)

…capsule-integration-final

sonarqubecloud · 2025-01-17T08:18:15Z

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

LeonmanRolls · 2025-01-22T06:33:19Z

src/components/@molecules/TransactionDialogManager/stage/query.ts

@@ -203,6 +230,10 @@ const createTransactionRequestUnsafe = async ({
    transactionName: params.name,
  })

+  const isCapsuleConnected = hasCapsuleConnection(connections)
+
+  const largestMedianGasFee = await getLargestMedianGasFee()


don't need to do this unless it's capsule

LeonmanRolls · 2025-01-22T06:40:11Z

src/hooks/pages/profile/useRenew/useRenew.test.ts

@@ -515,6 +509,7 @@ describe('useRenew', () => {
  })

  it('should handle URL changes', () => {
+    console.log('hi there')


storywithoutend

When not connected, testnet shows holesky

storywithoutend

If you log out and log in with capsule, sometimes the will not update to connected. You have to click connect > sign in with capsule in order for it to trigger login.

storywithoutend · 2025-01-23T05:10:24Z

src/components/@molecules/TransactionDialogManager/stage/TransactionStageModal.tsx

@@ -1,10 +1,11 @@
 import { queryOptions } from '@tanstack/react-query'


Perhaps "Open Wallet" is not the correct wording for a capsule transaction

storywithoutend · 2025-01-23T11:43:53Z

src/components/pages/profile/[name]/registration/steps/Pricing/Pricing.tsx

-    hasPendingMoonpayTransaction ? PaymentMethod.moonpay : PaymentMethod.ethereum,
+    hasPendingMoonpayTransaction || balance?.value === 0n
+      ? PaymentMethod.moonpay
+      : PaymentMethod.ethereum,
  )


When testing with capsule wallet moonpay wasn't the default choice.

storywithoutend · 2025-01-23T12:51:40Z

src/constants/chains.ts

+  const chainParam = params.get('chain')
+  const segments = hostname.split('.')
+
+  if (segments.length === 4 && segments.slice(1).join('.') === 'ens-app-v3.pages.dev') {


When logging into mainnet using the preview a holesky notification still appears. Also, the chain breaks when navigating to other pages since the search params are not passed.

storywithoutend · 2025-01-23T12:58:46Z

src/constants/chains.ts

+  return match(segments[0])
+    .with('sepolia', () => [
+      ...(isLocalProvider ? ([localhostWithEns] as const) : ([] as const)),
+      sepoliaWithEns,


Do we want to inject localhostWithEns here? Seems like we would want it to link to sepolia chain.

storywithoutend · 2025-01-23T12:59:30Z

src/hooks/pages/profile/useRenew/useRenew.test.ts

 vi.mock('wagmi')
 vi.mock('@app/transaction-flow/TransactionFlowProvider')
 vi.mock('next/navigation')

 const mockUseBasicName = mockFunction(useBasicName)
 const mockUseAbilities = mockFunction(useAbilities)
-const mockUseConnectModal = mockFunction(useConnectModal)
+// const mockUseConnectModal = mockFunction(useConnectModal)
 const mockUseAccount = mockFunction(useAccount)


storywithoutend · 2025-01-23T13:34:16Z

src/utils/query/capsuleWallet.ts

+
+export const capsuleModalProps = {
+  appName: '',
+  oAuthMethods: [


Is appName supposed to have a value?

storywithoutend · 2025-01-23T13:35:35Z

src/utils/query/capsuleWallet.ts

+const capsuleWalletItegratedOpts: GetCapsuleIntegratedOpts = {
+  capsule: capsuleClient,
+  nameOverride: 'Sign in with Capsule',
+  iconBackgroundOverride: '#ffffff',


translation for "Sign in with Capsule'?

storywithoutend · 2025-01-23T13:37:22Z

src/utils/query/capsuleWallet.ts

+  {
+    appName: APP_NAME,
+    projectId: '',
+  },


projectId should be WC_PROJECT_ID?

storywithoutend and others added 11 commits June 10, 2024 09:52

initial commit - basic capsule int

80de7e4

Merge branch 'main' into capsule-integration

2b8d819

chore: pnpm update

197987c

fix capsule

d0c5b9d

Merge branch 'main' into pr/786

2e9d342

onramp

95a1785

Update capsule rainbow

c25c67f

Merge branch 'main' of https://github.com/ensdomains/ens-app-v3 into …

abce894

…usecapsule-integration-two

Theme fix

fc317e9

dynamically load capsule wallet

6cd4116

fixes

0d36cef

github-actions bot deployed to ens-app-v3 (Preview) September 25, 2024 05:05 View deployment

disable worker

df18ce8

github-actions bot deployed to ens-app-v3 (Preview) September 25, 2024 06:12 View deployment

update deps

d1264aa

github-actions bot deployed to ens-app-v3 (Preview) October 7, 2024 08:33 View deployment

LeonmanRolls added 9 commits October 21, 2024 07:25

Merge branch 'main' of https://github.com/ensdomains/ens-app-v3 into …

6f4228d

…capsule-integration-final

check if wallet is capsule

03c25d6

Link to capsule wallet when connected with capsule

c5d303e

Update Pricing.tsx

a6d1653

Default to moonpay when balance is zero

Merge branch 'main' of https://github.com/ensdomains/ens-app-v3 into …

26cbe06

…capsule-integration-final

Remove hotfix

b183869

load capsule tests

876dfe5

Mock capsule rainbowkit

372d4a8

Fix types

c2e6188

github-actions bot deployed to ens-app-v3 (Preview) October 24, 2024 04:25 View deployment

LeonmanRolls marked this pull request as ready for review October 24, 2024 04:36

LeonmanRolls requested a review from sugh01 as a code owner October 24, 2024 04:36

TateB requested changes Oct 24, 2024

View reviewed changes

LeonmanRolls added 24 commits January 7, 2025 21:23

Merge branch 'main' of https://github.com/ensdomains/ens-app-v3 into …

aecfc6d

…capsule-integration-final

...

a246a9e

Unit tests

a2725f0

Transports fix

1b86df6

Fix capsule median gas fee calc func

db59678

useRenew test fixes

cfaa56d

Test fixes

2e10efa

Type fixes

a846847

Test fixes

8caf073

Merge branch 'main' of https://github.com/ensdomains/ens-app-v3 into …

d1d7916

…capsule-integration-final

...

051bfa9

connect wallet working

2d32bfc

Don't send switchChain to wallet unnecessarily

7ed90d8

holesky fix

86f3d28

...

32726be

Test fix

50a4d27

CI fix

a510e6a

stateful tests on holesky

557d1f1

lint fix

d59437d

e2e fix

e045ea4

Default to holesky

ff83364

Clean up comments

a886587

Don't switch chain when using web3-headless-wallet

d06c9a5

merge and fix build

145530a

LeonmanRolls commented Jan 22, 2025

View reviewed changes

storywithoutend requested changes Jan 23, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Capsule integration final #883

Capsule integration final #883

LeonmanRolls commented Sep 25, 2024

cloudflare-workers-and-pages bot commented Sep 25, 2024 •

edited

Loading

TateB Oct 24, 2024

TateB Oct 24, 2024

TateB Oct 24, 2024

TateB Oct 24, 2024

TateB Oct 24, 2024

TateB Oct 24, 2024

TateB Oct 24, 2024

sonarqubecloud bot commented Jan 17, 2025

LeonmanRolls Jan 22, 2025

LeonmanRolls Jan 22, 2025

storywithoutend left a comment

storywithoutend left a comment

storywithoutend Jan 23, 2025

storywithoutend Jan 23, 2025

storywithoutend Jan 23, 2025

storywithoutend Jan 23, 2025

storywithoutend Jan 23, 2025

storywithoutend Jan 23, 2025

storywithoutend Jan 23, 2025

storywithoutend Jan 23, 2025

		const isCapsuleConnected = getIsCapsuleConnected(wagmiConfig.state)


		import '@rainbow-me/rainbowkit/styles.css'

		// prettier-ignore-file

		githubUrl: 'https://github.com/ensdomains',
		xUrl: 'https://twitter.com/ensdomains',

		@@ -1,10 +1,11 @@
		import { queryOptions } from '@tanstack/react-query'

Capsule integration final #883

Are you sure you want to change the base?

Capsule integration final #883

Conversation

LeonmanRolls commented Sep 25, 2024

cloudflare-workers-and-pages bot commented Sep 25, 2024 • edited Loading

Deploying ens-app-v3 with Cloudflare Pages

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 17, 2025

Quality Gate failed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

storywithoutend left a comment

Choose a reason for hiding this comment

storywithoutend left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Sep 25, 2024 •

edited

Loading