-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENSIP-18: Profile Text Records #154
Conversation
Thoughts about a standard It doesn't come up often, but a few people have asked for that. Usually in the context of an avatar, like they're trying to put an MP4 file for that avatar which won't work most places. This could be an intro video for a project/company, or a CV (video reel / audio reel), or just anything that the ENS user would like people to see or hear when they visit their profile, on any sites that happen to support it. |
hmm... myspace throwback... could be nice, but that feels like it's verging on "profile content" rather than "profile describers", am definitely open to it though |
It would be nice also to have a list of all the various text records seen in the wild along with the examples of how it should be displayed. Kind of HIG thing. |
Here is a list of the top20 text records (+count) based on our indexing at Zapper:
|
@mehdi-loup OH wow! Niiicee! TYTY |
Just throwing out some random ideas and thoughts:
|
yes
accepted MIMEs are outlined in ENSIP-12, but target file sizes are not so it might be worth adding it to that existing spec since it's still a draft. imo timeout handling should be down to client implementation rather than the spec itself.
i don't think records that would never affect external viewers are particularly relevant.
this can just be dynamically resolved via ENS
this has a lot of overlap with your suggested
when setting text records on a (public) ens name, isn't this already assumed for every record?
not sure how useful this would be, can you give an example?
already included in
i was aware of this record, but i'm reluctant to expand support for it given existing handling for usernames/domain names/emails and the reasons that those all tend to be lower-cased.
definitely think this is a useful idea, will add.
i think there is reason to potentially add those as global keys at some point, but as with some of the pre-existing global keys (
can't really see this being implemented in many places. there would also be various security issues with this.
i'll add a section regarding vendor usernames. they should always be without any sort of prefix/suffixes.
currently i don't think this spec includes internal preferences, not sure what records you're talking about specifically
yes
not opposed to creating a convention for it but given the very limited use-cases for it, i don't think it's necessary right now
it's very context specific, but i don't think we need to worry about that right now
i think value sanitation is implied
this is pretty much already applied. image resources are ENSIP-12, urls must be valid, timezone is from tz database, etc
what would this be used for?
this would just be useful for
will add examples |
- added examples for all records - added section on profile service keys
@TateB love this! I definitely think there's some huge room for improvement in ENS profiles. Selfishly I think that messaging use cases (such as with XMTP) could benefit a lot from some of the additions you've proposed here. Questions/Feedback(in no specific order)
|
@TateB I appreciate all the responses! I think I got off-track when I interpreted "color-scheme" as a preference and then started thinking about user-settings... 😆️
Again, not advocating, just brainstorming. Do we need anything like an optional |
there is definitely potential for confusion, but as you identified, the main reason for
the spec briefly touches on nearest neighbour colours, but an example implementation/library for other apps to use makes sense to me
this is specifically about cropping, both for setting and retrieving avatars. "blank space" refers to the avatar not fitting the 1:1 aspect ratio. when setting, it means making sure the avatar is 1:1 aspect ratio (for non-nft images). when retrieving, it means if an avatar isn't 1:1, it should be filled to be 1:1 from the centre with no extra space. i'll try to reword the "blank space" sentence but i might just remove it, seems like it creates more confusion.
it's intentional that
will add
i'll add that specifically optional service-specific symbols should be removed, rather than all
can you clarify what you're saying here? i don't really get what you're suggesting |
generally i don't know how willing someone would be to spend pretty much 2x gas for something they won't benefit from. we could create a standard for a query string to use when retrieving avatars/headers though. it wouldn't be that hard to implement into existing ENS avatar resolution implementations |
Would a query string solve file size considerations for the avatar/header? Running a smooth dapp can be rough when someone logs in with a 1 gig profile pic and it'd be nice to not have to resize on the fly. Alternatively/ Additionally: consider a max file size recommendation for avatar/headers? |
I think 64px, 128px, 256px, 512px are good choices. Maybe an option to load a high-res with a limit size? |
opening feedback for the ENS profile spec, most crucially for:
color-scheme
, how it should be formatted, etcavatar
/header
design considerations (cropping)