-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix subscription removal for multiple remotes (#26)
- When a service has multiple similar remote devices (EVSEs with attached EVs), then removing an EV did remove the subscriptions for all remote EVs and therefor these wallboxes switched into fallback mode. This change fixes this - Add more tests for NodeManagementDetailedDiscovery entity removal
- Loading branch information
Showing
5 changed files
with
132 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
spine/testdata/wallbox_detaileddiscoverydata_recv_notify_remove.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
{ | ||
"datagram": { | ||
"header": { | ||
"specificationVersion": "1.3.0", | ||
"addressSource": { | ||
"device": "Wallbox", | ||
"entity": [ | ||
0 | ||
], | ||
"feature": 0 | ||
}, | ||
"addressDestination": { | ||
"device": "HEMS", | ||
"entity": [ | ||
0 | ||
], | ||
"feature": 0 | ||
}, | ||
"msgCounter": 4, | ||
"cmdClassifier": "notify", | ||
"ackRequest":true | ||
}, | ||
"payload": { | ||
"cmd": [ | ||
{ | ||
"function": "nodeManagementDetailedDiscoveryData", | ||
"filter": [ | ||
{ | ||
"cmdControl": { | ||
"partial": {} | ||
} | ||
} | ||
], | ||
"nodeManagementDetailedDiscoveryData": { | ||
"deviceInformation": { | ||
"description": { | ||
"deviceAddress": { | ||
"device": "Wallbox" | ||
} | ||
} | ||
}, | ||
"entityInformation": [ | ||
{ | ||
"description": { | ||
"entityAddress": { | ||
"entity": [ | ||
1, | ||
1 | ||
] | ||
}, | ||
"entityType": "EV", | ||
"lastStateChange": "removed" | ||
} | ||
} | ||
] | ||
} | ||
} | ||
] | ||
} | ||
} | ||
} |