Update igraph and fix build #589
Conversation
* genlib_writer * netlist_simulator_controller * resynthesis * simulator
xiota
requested review from
SimonKlx,
nils1603,
SJulianS,
joern274 and
swallat
as code owners
|
Thank you for these updates. |
|
Thanks for the contribution! We may want to reconsider the choice for which plugins to build by default; your proposed change in 98a8e06 would cause the build to include the entire simulator toolchain by default, which comes with a bunch of dependency concerns. See my comment here: #588 (comment) @SJulianS: any reservations against bumping igraph to 0.10.13? |
|
Consider bumping to 0.10.15. |
|
This PR no longer cleanly applies to HEAD. Was previously planning to rebase, but decided not to because emsec developers did not respond to the issue report or this PR. With latest commit (f715873), cherry-picking the following commits from this PR should allow successful build with vendored igraph (0.10.12). Building all plugins produces errors related to |
|
@xiota : I guess it is me who is to blame for "emsec developer did not respond". I am sorry that I could not deal with this PR until now. Previously I was testing Arch Linux related fixes on a virtual machine running under VMplayer which doesn't work any more after VMware became part of the Broadcom company. There might be many workarounds (making this a lousy excuse :-) - however, they will need time and effort, thus Arch Linux related fixes have been postponed a little bit. |
|
@joern274 Thanks for the explanation. I didn't want to open more Issues/PRs in case they weren't wanted or end up being more distracting than helpful. It did look like someone might have seen the issue and PR because some commits were potentially related. Now only the two aforementioned commits from this PR (f67c717, c3d3b81) are needed to build. A working PKGBUILD that applies them is available at |
Fixes problems preventing build on Arch Linux. Closes #588