[wasm64] Remove temporary toIndexType workaround #22773
Open
+3
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the firefox and chrome both use BigInt for indexing 64-bit memories and tables this workaround is no longer needed.
sbc100
force-pushed
the
remove_toIndexType
branch
from
30271f3
to
0dd9f78
Compare
dschuff
approved these changes
Oct 22, 2024
kripken
approved these changes
Oct 22, 2024
| @@ -964,8 +964,7 @@ function from64Expr(x, assign = true) { | |||
| } | |||
|
|
|||
| function toIndexType(x) { | |||
| if (MEMORY64 != 1) return x; | |||
| return `toIndexType(${x})`; | |||
| return to64(x); | |||
There was a problem hiding this comment.
Should we replace calls from toIndexType to to64? Or do we think the distinction is important/might matter later?
There was a problem hiding this comment.
I lean towards keeping the distinction, but just a thought.
There was a problem hiding this comment.
Yes, I thought of doing that. Can always be done as followup I guess?
There was a problem hiding this comment.
Followup sounds fine, but also I am not sure if that is worthwhile. Unless we are certain we won't care about the difference later (which I am not sure of myself).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the firefox and chrome both use BigInt for indexing 64-bit memories and tables this workaround is no longer needed.