Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the unfinished aios #199

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Fix the unfinished aios #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a204d23
* FIX [mqtt_quic] Clean cached qos aios and msgs.
wanghaEMQ Jul 25, 2023
b2886ce
* FIX [mqtt_quic] Fix the unfinished aio.
wanghaEMQ Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mqtt/protocol/mqtt/mqtt_quic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1621,7 +1621,7 @@
nni_lmq_flush(&p->recv_messages);
if(s->multi_stream)
nni_lmq_flush(&p->send_inflight);
// nni_id_map_foreach(&p->sent_unack, mqtt_close_unack_msg_cb);
nni_id_map_foreach(&p->sent_unack, mqtt_close_unack_msg_cb);

Check warning on line 1624 in src/mqtt/protocol/mqtt/mqtt_quic.c

View check run for this annotation

Codecov / codecov/patch

src/mqtt/protocol/mqtt/mqtt_quic.c#L1624 

Added line #L1624 was not covered by tests
nni_id_map_foreach(&p->recv_unack, mqtt_close_unack_msg_cb);
p->qpipe = NULL;
p->ready = false;
Expand Down
8 changes: 4 additions & 4 deletions src/supplemental/mqtt/mqtt_msg.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,10 +897,10 @@
nni_msg * msg = val;
nni_aio * aio = NULL;

// aio = nni_mqtt_msg_get_aio(msg);
// if (aio && nni_aio_begin(aio) == true) {
// nni_aio_abort(&aio, NNG_ECLOSED);
// }
aio = nni_mqtt_msg_get_aio(msg);
JaylinYu marked this conversation as resolved.
Show resolved Hide resolved
if (aio) {
nni_aio_finish_error(aio, NNG_ECLOSED);

Check warning on line 902 in src/supplemental/mqtt/mqtt_msg.c

View check run for this annotation

Codecov / codecov/patch

src/supplemental/mqtt/mqtt_msg.c#L900-L902 

Added lines #L900 - L902 were not covered by tests
}
nni_msg_free(msg);
}

Expand Down
Loading