Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the getattr patch #699

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Updated the getattr patch #699

merged 2 commits into from
Jan 17, 2024

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Jan 16, 2024

Description

Ensure that we can access annotations added by imported ontologies.

This issue was revealed when running the periodictable script for EMMO 1.0.0-beta5.

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

Ensure that we can access annotations added by imported ontologies.
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7a2d993) 71.36% compared to head (1ea0f87) 71.33%.

Files Patch % Lines
ontopy/patch.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
- Coverage   71.36%   71.33%   -0.04%     
==========================================
  Files          16       16              
  Lines        3391     3394       +3     
==========================================
+ Hits         2420     2421       +1     
- Misses        971      973       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@francescalb francescalb merged commit 13a3d83 into master Jan 17, 2024
10 of 12 checks passed
@francescalb francescalb deleted the fix-getattr-patch branch January 17, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants