Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to owlready0.45 #682

Closed
wants to merge 16 commits into from
Closed

Update to owlready0.45 #682

wants to merge 16 commits into from

Conversation

francescalb
Copy link
Collaborator

Description

  1. Owlready 0.45 introduced explicit type on all literals. This needs and update in get_version.
  2. python_names are added into the ontology for properties. this is not something we desire in EMMO, and hence these should be removed as default when saving in EMMOntoPy.
  3. Point 2 requires a copy funtion so that the ontology itself is not changed upon saving.

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

@francescalb francescalb marked this pull request as draft November 24, 2023 14:40
francescalb and others added 12 commits November 24, 2023 15:50
@francescalb
Added test for copy_function
dc4a7e9
@francescalb
Merge branch 'update_owlready0.45' of github.com:emmo-repo/EMMOntoPy …
79520f1 
…into update_owlready0.45
@francescalb
Added copy version 1 in ontology
2612ee0 
Note that this is done by squashing and saving which also
changes the original ontology. This should be avoided.
The excelparser-ontology fails for this reason?
@francescalb
pre-commit updates
ecfd73b 
Format is used as argument for ontology.save in owlready2 and cannot
be changed.
ontology.save in owlready2 takes file as argument, ontopy is updated
accordingly and keeping filename as optional with deprecation warning.
Same is done for dir to directory as dir is a predefined built-in in
python and should not be redefined.
@francescalb
Update argument name for save
a2cae97
@francescalb
Tryoing out different versions of copy
2a63ce4
@jesper-friis
Merge branch 'master' into update_owlready0.45
4dd3268
@francescalb
Merge branch 'master' into update_owlready0.45
a61dff6
@francescalb
Merge branch 'master' into update_owlready0.45
b67b760
@francescalb
Merge branch 'master' into update_owlready0.45
270bfcb
@francescalb
Merge branch 'master' into update_owlready0.45
87f68a3
@francescalb
Temporary commit
811e230
@francescalb
Copy link
Collaborator Author

closed with #795 and previous PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francescalb @jesper-friis