Skip checking dimensional units for domain ontologies that doesn't load this class.

[jesper-friis]

Description

Do not check SI dimensional units if the checked domain ontology does not load that class.

Type of change

• Bug fix.
• New feature.
• Documentation update.
• Test update.

Checklist

This checklist can be used as a help for the reviewer.

• Is the code easy to read and understand?
• Are comments for humans to read, not computers to disregard?
• Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
• Has the documentation been updated as necessary?
• Does this close the issue?
• Is the change limited to the issue?
• Are errors handled for all outcomes?
• Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c2696ce) 70.09% compared to head (da03e1f) 70.67%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   70.09%   70.67%   +0.58%     
==========================================
  Files          16       16              
  Lines        3367     3369       +2     
==========================================
+ Hits         2360     2381      +21     
+ Misses       1007      988      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[francescalb]

In PR#658 test_emmocheck_module was added, but it is not actually testing anything when run with pytest. So apart tests/tools/test_emmocheck there i nothing that tests emmocheck here. The tool only checks that it runs, but nothing more (it passes as test even if the emmocheck fails)

Please update the test so that it is actually run and then that it fails when emmocheck fails.

[jesper-friis]

Please update the test so that it is actually run and then that it fails when emmocheck fails.

This PR just skip testing dimensionalities for ontologies that doesn't import the relevant modules. Isn't adding general tests for emmocheck another issue?

[francescalb]

Appoved, but make an issue about creating a test.