Corrected get_by_label to use only labels in the ontology #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note it workd forimported ontologies if the whole ontoogy is loaded from outside. However, it the ontology is created directly in python it is not able to access classes in imported ontologies with get_by_label.
Simplified implementation of label_annotations.
francescalb
commented
Aug 25, 2023
francescalb
commented
Aug 25, 2023
Cleaned up and added test for exact_match. This is currently not working. So there is something wrong with that.
…-repo/EMMOntoPy into get_by_label_ni_imported_ontologies
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
==========================================
+ Coverage 68.68% 68.82% +0.14%
==========================================
Files 16 16
Lines 3292 3301 +9
==========================================
+ Hits 2261 2272 +11
+ Misses 1031 1029 -2
|
ontopy/ontology.py
Outdated
| Detault to DEFAULT_LABEL_ANNOTATIONS module variable. | ||
| Label IRIs not in the ontology will need to be added to | ||
| ontologies in order to be accessible. | ||
| Default is None. |
There was a problem hiding this comment.
None (default), is equivalent to set label_annotations to the DEFAULT_LABEL_ANNOTATIONS module variable.
jesper-friis
approved these changes
Aug 30, 2023
francescalb
commented
Aug 30, 2023
francescalb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
get:by:label used to search wider than what ist was supposed to in the sense that is searched for prefLabels even when skos:prefLabel was not in the ontology.
Furthermore, documentation for get_by_label and get_by_label_all has been updated.
Type of change
Checklist
This checklist can be used as a help for the reviewer.
Comments