Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade envoy to 1.30.1 (patched) #5684

Merged
merged 4 commits into from
May 28, 2024

Conversation

Alice-Lilith
Copy link
Member

@Alice-Lilith Alice-Lilith commented May 16, 2024

Description

Upgrades Envoy to 1.30.1 with our custom commits. Lots of changed files since we're going from 1.27.2 -> 1.30.1.

Screenshot from 2024-05-16 09-20-05

(two tests from that screenshot since they were known flakes that had to be re-ran, the rest already passed and were just cached)

Lance Austin and others added 4 commits May 15, 2024 21:12
Bumps to Envoy 1.28.0 and regenerates compiled protos.

steps:
1. update envoy.mk to v1.28 commit with custom commits
2. ran `make update-base`

Signed-off-by: Lance Austin <[email protected]>
Updates go-control-plane to the latest version sync'd and tested against
Envoy 1.28.

Signed-off-by: Lance Austin <[email protected]>
Signed-off-by: Alice Wasko <[email protected]>
@Alice-Lilith
Copy link
Member Author

I initially cherry-picked Lance's old 1.28 commits to help since I was running into issues. They aren't needed in this branch anymore, but since they also aren't hurting anything, I was just going to leave them in unless anyone cares since the rebase to drop them would be annoying.

@Alice-Lilith Alice-Lilith marked this pull request as ready for review May 16, 2024 19:18
Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, what a mess! Yeah, let's get this landed. Thanks!!

@Alice-Lilith Alice-Lilith merged commit 8b343d5 into master May 28, 2024
40 checks passed
@Alice-Lilith Alice-Lilith deleted the alicewasko/dev/update-envoy branch May 28, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants