Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3 destroy for feeds with sub paths #188

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

emgarten
Copy link
Owner

@emgarten emgarten commented Feb 3, 2024

  • Updated AmazonS3FileSystem.GetFiles to account for sub paths when retrieving all files in the feed
    • This call is currently only used by Destroy, other scenarios should not be impacted
    • Previous behavior was resulting in the sub path being duplicated in the URI, which resulted in files not being found.
  • Updated the S3 sub path functional test to verify the feed is fully removed.

Fixes #185

@emgarten emgarten merged commit 102c3ac into main Feb 3, 2024
5 checks passed
@emgarten emgarten deleted the emgarten/subfeed-destroy branch February 3, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destroy s3 feed issue with feedSubPath
1 participant