Hotfix: Minimization with bounds properly minimize targets #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVHopp
commented
Jan 14, 2025
Scienfitz
approved these changes
Jan 14, 2025
AdrianSosic
approved these changes
Jan 15, 2025
AdrianSosic
force-pushed
the
hotfix/minimization
branch
from
8382f36 to
4cec8ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hot-fixes #460 by multiplying the output of the
objective.transformwith -1 if the target is bounded and to be minimized.This PR also introduces a test and a small example for verifying the desired behavior. The solution implemented here is only temporary and will be replaced with a proper mechanism soon.