Add manual benchmark workflow and S3 result persistence #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianliebig
requested review from
Scienfitz,
AdrianSosic and
AVHopp
as code owners
|
@fabianliebig Looking at your commit history, I think the "fixup" did not do what you wanted it to do, you might want to check that out again ;) |
fabianliebig
force-pushed
the
feature/persisting-benchmarking-results
branch
from
f1cdf02 to
87dce85
Compare
AVHopp
reviewed
Nov 18, 2024
AVHopp
requested changes
Nov 18, 2024
AdrianSosic
requested changes
Nov 18, 2024
AVHopp
reviewed
Nov 20, 2024
fabianliebig
force-pushed
the
feature/persisting-benchmarking-results
branch
2 times, most recently
from
6ef448e to
9b57f37
Compare
AdrianSosic
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Hi @fabianliebig, thx for the draft. Here a few initial comment
AVHopp
reviewed
Nov 22, 2024
AVHopp
reviewed
Nov 22, 2024
fabianliebig
force-pushed
the
feature/persisting-benchmarking-results
branch
4 times, most recently
from
aa83e58 to
22caf8e
Compare
fabianliebig
force-pushed
the
feature/persisting-benchmarking-results
branch
from
e99f861 to
1de1222
Compare
AVHopp
reviewed
Nov 25, 2024
AdrianSosic
reviewed
Nov 25, 2024
There was a problem hiding this comment.
Hi @fabianliebig, thanks so much. I think our discussion was definitely worth it, I like the path-based solution a lot more, and I also saw that you agree 👍🏼 very nice.
Here a few suggestions + problem catches. But no changes required for the architecture! Will have to jump now but will look at the revised version later this evening.
fabianliebig
force-pushed
the
feature/persisting-benchmarking-results
branch
2 times, most recently
from
c68866a to
31cd5b2
Compare
Scienfitz
reviewed
Nov 25, 2024
AVHopp
approved these changes
Nov 26, 2024
fabianliebig
force-pushed
the
feature/persisting-benchmarking-results
branch
from
e4d7bf7 to
b03befc
Compare
fabianliebig
added
enhancement
Scienfitz
added
benchmarking
and removed
enhancement
…zable and adding a dedicated serialization module
…g folder and filename construction. This commit will drop the workflow id to allow overwriting and make the path homogenous constructable.
…nual pipeline run
…ure and persistence capabilities
…te persistence handling for GitHub CI
…prove path construction for benchmark results
fabianliebig
force-pushed
the
feature/persisting-benchmarking-results
branch
from
b03befc to
d260235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
This pull request introduces a class and a workflow designed to store the results of a benchmark run on an S3 bucket.
The key used for storage includes the identifier for the benchmark itself, the branch used, the release version, the current date and the commit hash in that order. Furthermore, boto3 package is added to interact with AWS components.
I look forward to your feedback.