UI: Add missing RBD parameter #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rbd_keyring_conf parameter has been marked as deprecated in Cinder because it should not be used within OpenStack, as users there can see the connection information and would then gain access to the whole cluster. But in Ember-CSI is completely different, because here normal users should not have access to the Ember-CSI CRD objects where this information is kept. Since we are removing deprecated options by default this option was removed from the form and examples, so in this patch we forcefully add it in the generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rbd_keyring_conf parameter has been marked as deprecated in Cinder
because it should not be used within OpenStack, as users there can see
the connection information and would then gain access to the whole
cluster.
But in Ember-CSI is completely different, because here normal users
should not have access to the Ember-CSI CRD objects where this
information is kept.
Since we are removing deprecated options by default this option was
removed from the form and examples, so in this patch we forcefully add
it in the generator.