Make magit-toggle-text-mode work in git-rebase-mode buffers #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magit's git-rebase-mode uses a different mode and a different keymap from the main Magit buffer. toggle-text-mode also needs to disable read-only-mode in rebase-mode buffers.
emlun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evil-collection-magit-toggle-text-modecurrently doesn't work ingit-rebase-modebuffers, as thecondchecks only for'magit-mode. Thus the function just shows the error "evil-collection-magit-toggle-text-mode unexpected state" if invoked in agit-rebase-modebuffer. TheC-tand\bindings are also not set while in this mode.These changes make
evil-collection-magit-toggle-text-modealso work ingit-rebase-mode, and set up the same key bindings in this mode. Becausegit-rebase-modealso enablesread-only-modein the buffer, we need to disable that too when switching totext-mode.