Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uha calculator new #2

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Uha calculator new #2

wants to merge 13 commits into from

Conversation

DracoTempus
Copy link

No description provided.

DracoTempus and others added 13 commits September 25, 2020 19:38
@DracoTempus
Added History button
e6f0c70
@DracoTempus
Made some changes to make it look nicer.
7fb8ef2
@SBoddeboyina-cx
Adding Uha's changes
66fd623
@SBoddeboyina-cx
Adding Uha's changes
cf44839
@DracoTempus
Merge branch 'Uha_Calculator'
2441a65
@ThomasSkowronski
Add the ability to square an expression.
fb1f8ef 
squares the expression on the screen and immediately displays the result.
@ThomasSkowronski
Merge branch 'master' of https://github.com/DracoTempus/android-calcu…
d6e7af1 
…lator
@ThomasSkowronski
added a button to square an expression
d4703fa 
This button will square the total of the current expression and calculate the result immediately.
@SBoddeboyina-cx
pushing Main_activity changes
573596e
@DracoTempus
added Uha Changes
dc46298
@DracoTempus
Fixed exponent I broke
3a45088 
I broke the exponent when I merged Uha's stale commit.  I fixed the issue, sorry about that.
@DracoTempus
Add uha changes. Though I see some things that are broken. I fixed a …
67d7f75 
…few.
@SBoddeboyina-cx
fixed bug where it uses a wrong variable switch cases in button_Cance…
e341f24 
…lPreviousCalculations routine
@eloyzone
Copy link
Owner

Thank you for contribution and your attempts.

I reviewed your commits, but please fix the following issues:

  1. I cannot figure out the difference of "Cancel" and "Clear or C" buttons, they have same behavior. (It's better to have one button to clear all inputs and one button to clear the history section)
  2. C and Cancel buttons does not look good.
  3. remove irrelevant comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DracoTempus @eloyzone @SBoddeboyina-cx @ThomasSkowronski