Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Attachments #3580

Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open

[WIP] Attachments #3580

wants to merge 5 commits into from

Commits on Mar 19, 2022

  1. Play with attachments, moving the download code out of the controller

    @emanuele45
    emanuele45 committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    cb7e9ed View commit details
    Browse the repository at this point in the history

  2. The id is a backward compatibility thing that dates back to SMF 1.1-r… 

    …c2 => dropped
    @emanuele45
    emanuele45 committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    44a6ef5 View commit details
    Browse the repository at this point in the history

  3. Docblocks

    @emanuele45
    emanuele45 committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    9f169a6 View commit details
    Browse the repository at this point in the history

  4. After having dropped relics of the past, the constructor needs only 1… 

    … parameter
    @emanuele45
    emanuele45 committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    e55ab2e View commit details
    Browse the repository at this point in the history

  5. $inline not used at that point, no need to change its value

    @emanuele45
    emanuele45 committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    2dcbd0d View commit details
    Browse the repository at this point in the history