Ensure install.sh exits if either of OTP or Elixir fails to install #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I didn't change install.bat because it does not install in parallel and so doesn't have this issue. |
|
cc @wojtekmach |
wojtekmach
approved these changes
Nov 14, 2024
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script uses
set -eto immediately exit the program if any commands return non-zero, butwaitwithout arguments does not reliably return with the exit code of a failed subprocess. (Exactly which exit code is returned depends, I believe, on the order in which the subprocesses exit.)By waiting on both pids explicitly, we ensure that the script exits if either OTP or Elixir fails to install. In the case of #1781, this change makes it so that the script halts after the
curlfails to download OTP master instead of carrying on as if nothing failed.