Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI updates #566

Merged
merged 5 commits into from
Oct 7, 2023
Merged

CI updates #566

merged 5 commits into from
Oct 7, 2023

Conversation

greg-rychlewski
Copy link
Member

@greg-rychlewski greg-rychlewski commented Oct 7, 2023

Changes:

  • I updated the CI to use Elixir 1.15 but what happened was it broke some of the migration tests. They were using @moduletag direction: :forward | :backward to run them properly and it seemed like it was relying on the ordering of the lines in the test file. I changed it to describe tag instead and it worked. Also I didn't use OTP 26 because a bunch of tests broke due to map key orderings. But I can work on fixing that a bit later.
  • I'm not sure you'll agree, but I moved the unit tests to github actions because it seemed a bit cleaner to me and I believe Earthly is not really needed unless it's for integration tests? But I can revert this if you prefer the old way

Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Agreed on using earthly for integration tests. :)

@greg-rychlewski greg-rychlewski merged commit dd95050 into elixir-ecto:master Oct 7, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants