New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add comment to removed columns #545

Merged

greg-rychlewski merged 1 commit into elixir-ecto:master from greg-rychlewski:remove_column_comment

Jul 30, 2023

Member

greg-rychlewski commented Jul 30, 2023 •

edited

Loading

Closes #544

edit:

Some things I checked:

It's not an issue for MySQL/TDS. MySQL is handling the case already. TDS doesn't seem like it supports comments.
remove_if_exists doesn't support opts so don't have to worry about it.
it makes sense to allow the comment option for this operation because of the reverse operation


          don't add comment to removed columns

a5dbf0d

josevalim approved these changes

View reviewed changes

greg-rychlewski merged commit 8450566 into elixir-ecto:master

9 checks passed

greg-rychlewski deleted the remove_column_comment branch

August 21, 2023 02:41

josevalim pushed a commit that referenced this pull request


          Don't add comment to removed columns (#545)

35c12f7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet