Fix mysqldump generating use database
#541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #539.
There are 2 things:
--databases
flag, which automatically adds theuse
statement. So don't allow this for MySQL.dump_cmd
was created therun_with_cmd
was refactored to add the--databases
flag. Most likely in attempt to reduce duplication/clean up the code. Putting the database specification back into the callers because they are too different to generalize here (i.e. dump_with_cmd wants to use the config database, but structure_dump wants to allow custom prefixes).