-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add project boilerplate from template #3
Conversation
Signed-off-by: pushkarm029 <[email protected]>
Reviewer's Guide by SourceryThis pull request initializes the project structure for the 'cloud-telemetry' repository using a cookiecutter template. It sets up the basic project layout, configuration files, documentation structure, and CI/CD workflows. The changes include adding essential files for project management, development workflows, and code quality checks. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Pushkarm029 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟡 Security: 1 issue found
- 🟡 Testing: 3 issues found
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Signed-off-by: pushkarm029 <[email protected]>
Signed-off-by: pushkarm029 <[email protected]>
Signed-off-by: pushkarm029 <[email protected]>
some tests fail because the |
Signed-off-by: pushkarm029 <[email protected]>
Signed-off-by: pushkarm029 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably upgrade to the latest version of the Cookiecutter - and after elixir-cloud-aai/cookiecutter-python#14 has been merged (hopefully today/tomorrow).
Another possible concern is that it is not entirely clear to me yet what the code will look like. Does it make sense to distribute it as a package on PyPI (my guess is yes)? Can you foresee any use for a console script included in the project, i.e., some CLI client (my guess is no)?
Depending on these, perhaps some of the generated content should be adjusted (e.g., the console script section removed from pyproject.toml
, the release_pypi.yaml
workflow removed etc).
Other than that, I think it's good to go.
So please update Cruft once the Cookiecutter PR is merged, then please have another look at the generated content and check if there's anything that you think may not fit your project. In case you are unsure, just leave it - we can always change things later on. When you are done with that, please ask for a re-review and I will approve.
I have added |
Signed-off-by: pushkarm029 <[email protected]>
Signed-off-by: pushkarm029 <[email protected]>
Signed-off-by: pushkarm029 <[email protected]>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
@Pushkarm029: Please fix the linting and doc check issues. @JaeAeich: Maybe you can help with the doc check one? |
@Pushkarm029 you haven't generated the docs, please do so by running For linting you could either manually add fullstop in the pydoc of init.py file, or wait for #15 to merge and run |
Cookiecutter template has been updated, running |
Signed-off-by: pushkarm029 <[email protected]>
I updated the cookiecutter by directly creating a new one. because on using (.venv) pushkarm029@thinkpad:~/cloud-telemetry(cookie-cutter⚡) » make u
Updating the template +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Using latest version from remote: https://github.com/elixir-cloud-aai/cookiecutter-python.
Command not found: cruff
make: *** [Makefile:118: update] Error 1 |
yeah, should be fixed in #16, idk how that got slipped in, if you find any more such issues, please report in the issues sections :). |
Yeah, why not @JaeAeich, let us merge this then |
@uniqueg, could you approve this again to merge? |
Summary by Sourcery
Initialize the 'cloud_telemetry' project using a cookiecutter template, setting up the project structure, documentation, CI/CD workflows, and initial test framework. This includes adding a README, Makefile, GitHub Actions for CI, and configuration files for documentation and code quality tools.
New Features:
Enhancements:
Build:
CI:
Deployment:
Documentation:
Tests:
Chores: