Updates comments

eliocamp · Sep 19, 2021 · 1eb7caf · 1eb7caf
1 parent 7f63f86
commit 1eb7caf
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 14 deletions.
diff --git a/cran-comments.md b/cran-comments.md
@@ -1,21 +1,24 @@
 
 ## Test environments
 
-* local installation of elementary OS 5.1.7 Hera (Built on Ubuntu 18.04.4 LTS) R version 4.1.0
-
-* R-hub
-    - Ubuntu Linux 20.04.1 LTS, R-release, GCC
-    - Windows Server 2008 R2 SP1, R-devel, 32/64 bit
+* local installation of elementary OS 5.1.7 Hera (Built on Ubuntu 18.04.4 LTS) R version 4.1.1
 
 * winbuilder
-    - R Under development (unstable) (2021-08-05 r80717)
+  - R Under development (unstable) (2021-09-17 r80929)
+  - Ubuntu Linux 20.04.1 LTS, R-release, GCC
+
+
+* rhub
+  - Windows Server 2008 R2 SP1, R-devel, 32/64 bit
 
 
 ## R CMD check results
 
 0 errors | 0 warnings | 1 notes 
 
-I get some notes only in winbuilder. I believe these are false positives.
+I get these notes that seem like false positives, since I can browse to those
+URLs with no problems.
+
 
 Found the following (possibly) invalid URLs:
   URL: https://doi.org/10.1175/1520-0469(1985)042<0217:OTTDPO>2.0.CO;2
@@ -34,15 +37,9 @@ Found the following (possibly) invalid URLs:
     From: man/EPflux.Rd
     Status: 403
     Message: Forbidden
-
-
-I also get this one, which I also seems like a false positive, since I can browse to that
-URL with no problems.
-
   URL: https://glossary.ametsoc.org/wiki/Standard_atmosphere
     From: man/standard_atmosphere.Rd
     Status: Error
     Message: SSL certificate problem: unable to get local issuer certificate
 
-
 Thanks for all the work :)
diff --git a/vignettes/Working-with-data.Rmd b/vignettes/Working-with-data.Rmd
@@ -154,7 +154,7 @@ Where the 1st Principal Component is clearly the [Antarctic Oscillation](http://
 
 ## ImputeEOF
 
-As shown above, `EOF()` needs a complete data matrix. Imputing missing values is a huge problem on it's own with a lot of different algorithms. `metR` offers `ImputeEOF()`, which is an implementation of the [DINEOF](http://modb.oce.ulg.ac.be/mediawiki/index.php/DINEOF) algorithm for imputation of missing data. It's interface is similar to that of `EOF()` but it returns a vector of imputed values. 
+As shown above, `EOF()` needs a complete data matrix. Imputing missing values is a huge problem on it's own with a lot of different algorithms. `metR` offers `ImputeEOF()`, which is an implementation of the [DINEOF](https://doi.org/10.12681/mms.64) algorithm for imputation of missing data. Its interface is similar to that of `EOF()` but it returns a vector of imputed values. 
 
 ```{r}
 geopotential <- geopotential[]