Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: New codelabs about composition & generics (PHP Symfo) #1033

Merged
merged 24 commits into from
Jan 10, 2024
Merged

Feat: New codelabs about composition & generics (PHP Symfo) #1033

merged 24 commits into from
Jan 10, 2024

Conversation

ArthurJCQ
Copy link
Member

No description provided.

@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine November 6, 2023 16:03 Destroyed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023 •
edited
Loading

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine/ 🟠 80 🟢 100 🟢 92 🟢 92 🟠 70
/feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine/fr/authors/ajacquemin/ 🟠 87 🟢 100 🟢 92 🟢 92 🟠 70
/feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine/fr/comment-construire-site-web-avec-nextjs/ 🟠 83 🟢 98 🟠 83 🟢 100 🟠 70
/feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟠 72 🟢 98 🟠 83 🟢 97 🟠 70

Here's the audits:

Path FCP
1800 <=		 LCP
2500 <=		 Speed Index
3400 <=		 TTI
3800 <=		 TBT
200 <=		 CLS
0.1 <=
/feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine/ 🔴 2439 🔴 3309 🟢 2439 🔴 8559 🟢 15 🟢 0
/feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine/fr/authors/ajacquemin/ 🟢 1740 🔴 2936 🟢 1740 🔴 4600 🟢 9 🟢 0
/feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine/fr/comment-construire-site-web-avec-nextjs/ 🔴 2420 🔴 3629 🟢 2420 🔴 5530 🟢 8 🟢 0
/feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 2192 🔴 4709 🟢 2192 🔴 10333 🟢 17 🟢 0.07

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 19.7%, saving 168.06 KB.

Filename Before After Improvement Visual comparison
_assets/authors/ajacquemin.jpg 852.28 KB 684.21 KB -19.7% View diff

1142 images did not require optimisation.

@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine November 6, 2023 16:20 Destroyed
@ArthurJCQ
fixup! Fix notes & pic
0159c3d
@ArthurJCQ
Merge branch 'feat/add-tutorial-composition-over-inheritance-et-typag…
019981b 
…e-generique-avec-symfony-et-doctrine' of github.com:eleven-labs/blog.eleven-labs.com into feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine November 6, 2023 16:33 Destroyed
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine November 6, 2023 16:42 Destroyed
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine November 6, 2023 16:52 Destroyed
@ch3ric ch3ric added publication status/reviewable status: reviewable labels Nov 6, 2023
@ArthurJCQ
Merge branch 'master' into feat/add-tutorial-composition-over-inherit…
b5b4983 
…ance-et-typage-generique-avec-symfony-et-doctrine
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine November 7, 2023 09:07 Destroyed
@ArthurJCQ
Merge branch 'master' into feat/add-tutorial-composition-over-inherit…
8f61210 
…ance-et-typage-generique-avec-symfony-et-doctrine
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine November 8, 2023 09:05 Destroyed
ElevenMarianne
ElevenMarianne reviewed Nov 13, 2023
View reviewed changes
...023-11-22-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine/index.md Outdated
Comment on lines 18 to 23
steps:
- introduction
- initialisation-du-projet
- refactoring-du-repository
- typage-generique-avec-phpstan
- conclusion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je me demande si c'est possible d'avoir une pagination des étapes dans le titre ?
Parce que dans le dossier steps ce n'est pas ordonné, et j'aime bien quand c'est ordonné 😆

@ArthurJCQ
Merge branch 'master' into feat/add-tutorial-composition-over-inherit…
c3e41f9 
…ance-et-typage-generique-avec-symfony-et-doctrine
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine November 28, 2023 13:28 Destroyed
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine December 6, 2023 09:58 Destroyed
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine December 6, 2023 09:58 Destroyed
@ArthurJCQ
Merge branch 'master' into feat/add-tutorial-composition-over-inherit…
70cc34f 
…ance-et-typage-generique-avec-symfony-et-doctrine
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine January 3, 2024 13:01 Destroyed
Cindyvlv
Cindyvlv reviewed Jan 10, 2024
View reviewed changes
...omposition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine/steps/conclusion.md Outdated
slug: conclusion
title: Conclusion
---
### Conclusion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Conclusion
## Conclusion

...r-inheritance-et-typage-generique-avec-symfony-et-doctrine/steps/initialisation-du-projet.md Outdated
slug: initialisation-du-projet
title: Initialisation du projet
---
### Initialisation du projet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Initialisation du projet
## Initialisation du projet

...position-over-inheritance-et-typage-generique-avec-symfony-et-doctrine/steps/introduction.md Outdated
slug: introduction
title: Introduction
---
### Qu'allons-nous faire ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Qu'allons-nous faire ?
## Qu'allons-nous faire ?

...position-over-inheritance-et-typage-generique-avec-symfony-et-doctrine/steps/introduction.md Outdated
- [Codelab Symfo/Doctrine](https://github.com/ArthurJCQ/codelabs-compo)


### Pré-requis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Pré-requis
## Pré-requis

...-inheritance-et-typage-generique-avec-symfony-et-doctrine/steps/refactoring-du-repository.md Outdated
slug: refactoring-du-repository
title: Refactoring du repository
---
### Refactoring du repository
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Refactoring du repository
## Refactoring du repository

...eritance-et-typage-generique-avec-symfony-et-doctrine/steps/typage-generique-avec-phpstan.md Outdated
slug: typage-generique-avec-phpstan
title: Typage générique avec PHPStan
---
### Typage générique avec PHPStan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Typage générique avec PHPStan
## Typage générique avec PHPStan

@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine January 10, 2024 17:14 Destroyed
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine January 10, 2024 17:16 Destroyed
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine January 10, 2024 17:19 Destroyed
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine January 10, 2024 17:20 Destroyed
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine January 10, 2024 17:22 Destroyed
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine January 10, 2024 17:23 Destroyed
@ElevenTom
Update refactoring-du-repository.md
7075f57 
fix typos
changed h3 to h2
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine January 10, 2024 17:44 Destroyed
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine January 10, 2024 17:50 Destroyed
@ElevenTom
Merge branch 'master' into feat/add-tutorial-composition-over-inherit…
1e27f35 
…ance-et-typage-generique-avec-symfony-et-doctrine
@github-actions github-actions bot temporarily deployed to dev-feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine January 10, 2024 17:57 Destroyed
@ElevenTom ElevenTom merged commit ae78037 into master Jan 10, 2024
2 checks passed
@ElevenTom ElevenTom deleted the feat/add-tutorial-composition-over-inheritance-et-typage-generique-avec-symfony-et-doctrine branch January 10, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cindyvlv Cindyvlv Cindyvlv left review comments

@ElevenMarianne ElevenMarianne ElevenMarianne approved these changes

Assignees
No one assigned
Labels
publication status/reviewable status: reviewable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArthurJCQ @ElevenMarianne @Cindyvlv @ch3ric @ElevenTom