Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/highlighted post preview #1004

Merged
merged 16 commits into from
Nov 2, 2023
Merged

Feature/highlighted post preview #1004

merged 16 commits into from
Nov 2, 2023

Conversation

meugeniatr
Copy link
Contributor

No description provided.

@fpasquet fpasquet self-requested a review October 30, 2023 14:25
@meugeniatr meugeniatr force-pushed the feature/highlighted-post-preview branch from d6173ff to 5fee580 Compare October 31, 2023 10:19
@meugeniatr meugeniatr self-assigned this Oct 31, 2023
@meugeniatr meugeniatr force-pushed the feature/highlighted-post-preview branch from 9c8518b to b29a100 Compare October 31, 2023 22:20
@fpasquet
Copy link
Contributor

fpasquet commented Nov 1, 2023

Le isHighlighted dans cette PR doit être gérer sans l'image, car la gestion des image de couverture fait partie d'un autre ticket

fpasquet
fpasquet reviewed Nov 1, 2023
View reviewed changes
src/components/PostPreview/PostPreviewContent.tsx Outdated
);
};

export default PostPreviewContent;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default PostPreviewContent;

@meugeniatr meugeniatr force-pushed the feature/highlighted-post-preview branch from b29a100 to 6a4ad0c Compare November 2, 2023 09:02
@github-actions github-actions bot temporarily deployed to dev-feature/highlighted-post-preview November 2, 2023 09:52 Destroyed
@meugeniatr meugeniatr added status/mergeable status: mergeable status/reviewable status: reviewable labels Nov 2, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023 •
edited
Loading

⚡️🏠 Lighthouse report

Here's the summary:

Path Performance Accessibility Best practices SEO PWA
/feature/highlighted-post-preview/ 🟠 65 🟢 97 🟢 92 🟢 92 🟠 70
/feature/highlighted-post-preview/fr/authors/ajacquemin/ 🟠 67 🟢 97 🟠 83 🟢 92 🟠 70
/feature/highlighted-post-preview/fr/comment-construire-site-web-avec-nextjs/ 🟠 76 🟢 98 🟠 83 🟢 100 🟠 70
/feature/highlighted-post-preview/fr/nestjs-le-cycle-de-vie-dune-requete/ 🟠 72 🟢 98 🟠 83 🟢 97 🟠 70

Here's the audits:

Path FCP
1800 <=		 LCP
2500 <=		 Speed Index
3400 <=		 TTI
3800 <=		 TBT
200 <=		 CLS
0.1 <=
/feature/highlighted-post-preview/ 🔴 2555 🔴 8785 🟢 2722 🔴 8614 🟢 10 🟢 0
/feature/highlighted-post-preview/fr/authors/ajacquemin/ 🔴 2001 🔴 8364 🟢 2825 🔴 8139 🟢 9 🟢 0
/feature/highlighted-post-preview/fr/comment-construire-site-web-avec-nextjs/ 🔴 2810 🔴 3734 🔴 3433 🔴 10593 🟢 8 🟢 0
/feature/highlighted-post-preview/fr/nestjs-le-cycle-de-vie-dune-requete/ 🔴 2276 🔴 4926 🟢 3100 🔴 8649 🟢 7 🟢 0.07

@github-actions github-actions bot temporarily deployed to dev-feature/highlighted-post-preview November 2, 2023 10:26 Destroyed
@meugeniatr meugeniatr force-pushed the feature/highlighted-post-preview branch from e0f50e8 to 534c07f Compare November 2, 2023 15:14
@github-actions github-actions bot temporarily deployed to dev-feature/highlighted-post-preview November 2, 2023 15:16 Destroyed
@fpasquet fpasquet merged commit bd91987 into master Nov 2, 2023
2 checks passed
@fpasquet fpasquet deleted the feature/highlighted-post-preview branch November 2, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpasquet fpasquet fpasquet approved these changes

Assignees

@meugeniatr meugeniatr

Labels
status/mergeable status: mergeable status/reviewable status: reviewable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meugeniatr @fpasquet