Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch workspace when scrolling on the panel #567

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

leolost2605
Copy link
Member

Fixes #524

@leolost2605 leolost2605 requested a review from a team August 19, 2024 16:06
@lenemter
Copy link
Member

I think you forgot to add Services/WMDBus.vala file to git here 😅

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I can see the utility here but I think we probably need an off-by-default gsetting for this. I can already here the reports of folks triggering this by accident and thinking this is a bug since there's no visual indicator and there's nothing else workspace related in the panel

@leolost2605
Copy link
Member Author

I think you forgot to add Services/WMDBus.vala file to git here 😅

Whoops added it :)

Hm, I can see the utility here but I think we probably need an off-by-default gsetting for this. I can already here the reports of folks triggering this by accident and thinking this is a bug since there's no visual indicator and there's nothing else workspace related in the panel

Sure we can do that

@leolost2605
Copy link
Member Author

leolost2605 commented Aug 19, 2024

Can we expose it in settings?

@leolost2605
Copy link
Member Author

Proposed the setting at elementary/switchboard-plug-pantheon-shell#416 :)

@leolost2605
Copy link
Member Author

For a better experience I also opened elementary/wingpanel-indicator-power#264

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Cool feature :)

@danirabbit danirabbit merged commit 819f9a8 into master Aug 20, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the leolost/switch-workspace-on-scroll branch August 20, 2024 19:51
@JPLeBreton
Copy link

Thanks so much for implementing this! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mouse wheel scroll when hovering wingpanel switches workspaces
4 participants