Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fractional scaling #559

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Fix fractional scaling #559

merged 1 commit into from
Aug 12, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Aug 12, 2024 •
edited
Loading

Turns out we don't need to manually multiply anything :)

Otherwise we get very weird sizes

@leolost2605 leolost2605 requested a review from a team August 12, 2024 17:22
danirabbit
danirabbit approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in low and HiDPI here

@danirabbit danirabbit merged commit be6e705 into master Aug 12, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the leolost/fix-fractional-scales branch August 12, 2024 22:17
@danirabbit danirabbit mentioned this pull request Aug 15, 2024
Closed
@leolost2605 leolost2605 mentioned this pull request Aug 16, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leolost2605 @danirabbit