Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK4 prep: Use event controllers for open and scrubbing #544

Merged
merged 7 commits into from
Sep 10, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Jul 10, 2024

Also remove the grab last focused window operation.

@leolost2605 leolost2605 force-pushed the leolost/indicator-entry-event-controllers branch 2 times, most recently from 4ab0298 to 6f6c61c Compare July 11, 2024 11:08
@danirabbit danirabbit force-pushed the leolost/indicator-entry-event-controllers branch 2 times, most recently from 0278654 to dcbe69b Compare July 12, 2024 17:15
@danirabbit danirabbit force-pushed the leolost/indicator-entry-event-controllers branch from dcbe69b to ee22325 Compare July 12, 2024 17:17
@leolost2605
Copy link
Member Author

Just a quick note since I've seen some activity here: I think this PR doesn't work on X not 100% sure though. On that matter: Should we try our best to keep X compatability in GTK4 or should we rather do something similar to dock?

@danirabbit
Copy link
Member

@leolost2605 Yeah we have to keep a working X11 session until the new a11y stack is available. So I think it'd be better to work on getting things as prepped as possible without introducing any breakage for now

@leolost2605

This comment was marked as outdated.

@leolost2605 leolost2605 marked this pull request as ready for review July 29, 2024 11:37
@zeebok
Copy link
Contributor

zeebok commented Aug 23, 2024

@leolost2605 There are now conflicts with master to resolve

@leolost2605
Copy link
Member Author

Conflicts are resolved and this should now keep exactly the same behavior as current master

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaict scrubbing works as expected, everything seems to work okay, except the panel drag behavior doesn't work in X11. It looks like you used GestureMultiPress there, should it be instead a GestureDrag?

@leolost2605
Copy link
Member Author

afaict scrubbing works as expected, everything seems to work okay, except the panel drag behavior doesn't work in X11. It looks like you used GestureMultiPress there, should it be instead a GestureDrag?

It's also currently broken on master but I now found a fix that works in tandem with this so I fixed it here :)

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I can confirm this works in X11 and Wayland now :)

@danirabbit danirabbit merged commit 9969217 into master Sep 10, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the leolost/indicator-entry-event-controllers branch September 10, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants