-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTK4 prep: Use event controllers for open and scrubbing #544
Conversation
4ab0298
to
6f6c61c
Compare
0278654
to
dcbe69b
Compare
dcbe69b
to
ee22325
Compare
Just a quick note since I've seen some activity here: I think this PR doesn't work on X not 100% sure though. On that matter: Should we try our best to keep X compatability in GTK4 or should we rather do something similar to dock? |
@leolost2605 Yeah we have to keep a working X11 session until the new a11y stack is available. So I think it'd be better to work on getting things as prepped as possible without introducing any breakage for now |
This comment was marked as outdated.
This comment was marked as outdated.
@leolost2605 There are now conflicts with master to resolve |
Conflicts are resolved and this should now keep exactly the same behavior as current master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaict scrubbing works as expected, everything seems to work okay, except the panel drag behavior doesn't work in X11. It looks like you used GestureMultiPress there, should it be instead a GestureDrag?
It's also currently broken on master but I now found a fix that works in tandem with this so I fixed it here :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! I can confirm this works in X11 and Wayland now :)
Also remove the grab last focused window operation.