-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dark style in greeter session #499
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably isn't going to work in the expected way, or at all.
The Granite.Settings
object first queries the Portal, which probably isn't running in the greeter. Then it queries AccountsService, which is running, but Granite queries using the current user (which is lightdm
in the greeter session).
There's also a chance of hangs here because a lot of these DBus calls happen synchronously.
I would suggest that instead of this, the Greeter needs to communicate the dark style preference to the panel, rather than the panel process trying to detect it itself in the Greeter.
@davidmhewitt elementary/greeter#684 both launches portals in the greeter session and syncs dark style preference from selected user's AccountsService to lightdm's one. |
Complementary to elementary/greeter#684