Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SettingsPage: use gicon instead of icon_name #289

Merged
merged 2 commits into from
Feb 1, 2024
Merged

SettingsPage: use gicon instead of icon_name #289

merged 2 commits into from
Feb 1, 2024

Conversation

danirabbit
Copy link
Member

facilitate when the icon comes from AppInfo like elementary/switchboard-plug-notifications#99

@danirabbit danirabbit requested a review from a team January 31, 2024 21:43
This was referenced Jan 31, 2024
Merged
Merged
jeremypw
jeremypw approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected with linked plug PR; will need similar updates to other plugs.

@danirabbit danirabbit merged commit 5aa90d6 into main Feb 1, 2024
4 checks passed
@danirabbit danirabbit deleted the danirabbit/settingspage-gicon branch February 1, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw