Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CategoryView: cleanup #287

Merged
merged 3 commits into from
Feb 1, 2024
Merged

CategoryView: cleanup #287

merged 3 commits into from
Feb 1, 2024

Conversation

danirabbit
Copy link
Member

Review with "hide whitespace"

Screenshot from 2024-01-31 09 55 37
Screenshot from 2024-01-31 09 55 02

  • Bump copyright header
  • Inline namespace
  • Set padding/margin with CSS
  • Float searchbar
  • Fix scrollbar location
  • Reduce number of clamps, scrolled boxes, and stacks
  • Make objects way more private
  • Fix issues with search and keyboard nav
  • Code style
  • Remove an idle that caused plugs to load in late and make the view jump on launch every time

@danirabbit danirabbit requested a review from a team January 31, 2024 18:34
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as in main.

There is a regression compared to master in that pressing the Up key does not return to the search entry but that was not caused by this PR.

@jeremypw jeremypw merged commit 04fc6f0 into main Feb 1, 2024
4 checks passed
@jeremypw jeremypw deleted the danirabbit/categoryview-cleanup branch February 1, 2024 16:16
@danirabbit
Copy link
Member Author

Yeah I noticed it looks like maybe a change in behavior in GTK? the flowboxes don't seem to be able to keyboard nav between them either

@jeremypw
Copy link
Contributor

jeremypw commented Feb 1, 2024

Might be able to fix by putting the EventControllerKey in the CAPTURE phase and catching the Up key before it is swallowed by the FlowBox but its not a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants