-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTK Background #2070
Draft
leolost2605
wants to merge
30
commits into
main
Choose a base branch
from
leolost/gtk-background
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
GTK Background #2070
+857
−980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolost2605
force-pushed
the
leolost/gtk-background
branch
from
September 24, 2024 18:19
fe6872b
to
0ea8dea
Compare
Closed
this sounds like a huge undertaking. Please let me know whether you need someone to test/battleproof it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this wasn't particularly endorsed it also wasn't completely rejected on discord.
And because I hate Clutter and love GTK (a little exaggerated) I decided to go ahead and put together this little POC :)
Fixes #2114
Fixes #2057
Fixes #2080 (this is purely coincidental but since with this a newly launched window will never be the first on a workspace, the stack position is correct)
Fixes #1672 (while I can't reproduce that and it might already be fixed the backtrace there points to the background cache and source which is removed here so IMO it's pretty safe to assume it's fixed at the latest here)
TODO: