-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play login sound #1376
base: main
Are you sure you want to change the base?
Play login sound #1376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! One question: since the sound is being played on the workspace manager, wouldn't it be played if Gala crashes and is relaunched?
@JoseExposito yes if Gala would crash, the sound would be played again. Do you have any idea how to prevent this? |
Maybe you could use org.gnome.SessionManager to handle this case? I'm not sure if there is a signal/method you can use there. Gala already has a |
Code looks good, thanks!!! Handing over to the @elementary/ux team for their input. Personal opinion: I'm am not a big fan of login sounds, so I'll be happy if this was something configurable in settings. |
Yeah, I don't think a login sound is desirable by default. I could see the argument for a "ready" sound from an accessibility standpoint, but then it would need to be short and subtle enough to not be annoying every time you turn on your computer. We would also likely want a similar sound on the login screen to signal that's available for typing a password. Regardless, I think that would be off by default? |
@elementary/ux is there any interest in adding optional system sounds? |
Regarding the exact sounds, just posting them from here: |
Related to elementary/triage#98