Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : use RoomMembershipObserver to close room screen when leaving #3887

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Nov 18, 2024

Content

Close the room flow when leaving a room from the client.
If leaving, being banned from another client, the room screen will update but won't navigate up to the room list.

Motivation and context

Screenshots / GIFs

No ui change.

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added the PR-Bugfix For bug fix label Nov 18, 2024
@ganfra ganfra marked this pull request as ready for review November 18, 2024 15:17
@ganfra ganfra requested a review from a team as a code owner November 18, 2024 15:17
@ganfra ganfra requested review from bmarty and removed request for a team November 18, 2024 15:17
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/2rhUF2

Copy link

sonarcloud bot commented Nov 18, 2024

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.85%. Comparing base (86a6244) to head (e75d6fa).
Report is 20 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3887      +/-   ##
===========================================
- Coverage    82.87%   82.85%   -0.02%     
===========================================
  Files         1784     1784              
  Lines        45090    45088       -2     
  Branches      5324     5323       -1     
===========================================
- Hits         37368    37358      -10     
- Misses        5857     5865       +8     
  Partials      1865     1865              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant