Make themed widgets reflect the effective theme #28342
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that widgets such as Element Call will show up in the right theme even if the app is set to match the system theme.
t3chguy
reviewed
Oct 30, 2024
There was a problem hiding this comment.
I'm not sure this is the right solution given that system theme often changes based on time (day/night), and widgets have no way to receive a theme change. Maybe a widget should just make its own media queries if there is no provided theme to match system theme and that way it can respond to theme changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that widgets such as Element Call will show up in the right theme even if the app is set to match the system theme.
Closes #27671